Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing that the .emit call is a no-op when no listeners are registered. #24

Merged
merged 5 commits into from
Sep 3, 2022
Merged

Testing that the .emit call is a no-op when no listeners are registered. #24

merged 5 commits into from
Sep 3, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Sep 2, 2022 •
edited
Loading

Only emit when no listeners are listening to the specific event given.

Adds unit tests to test that the .emit(...) method returns quickly when no listeners are registered.

blink1073
blink1073 approved these changes Sep 3, 2022
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit e49adff into jupyter:main Sep 3, 2022
@Zsailer Zsailer mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zsailer @blink1073