Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tests from dist #36

Merged
merged 4 commits into from
Dec 8, 2020
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Dec 8, 2020

This is the lowest-change, easiest-to-review approach.

Can also work up something that:

  • adopts the generally-less-error-prone src/nbclassic/ approach or
  • adopts the generally-more-downstream-usable src/nbclassic/tests approach

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 8, 2020

grah, this is the new pip resolver thing, i guess. i dunno, folks. seems shady. I can keep fighting it, but am a bit out of the loop on all the renaming... and why it's bringing in 1.1.0dev in the first place, and why that constitutes a breaking change.

@bollwyvl bollwyvl force-pushed the remove-tests-from-dists branch from aa83703 to 2398e63 Compare December 8, 2020 02:25
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 8, 2020

Gah, we're back in the hell that is tornado vs windows vs asyncio vs py38+.

jupyter-server/jupyter_server#339 pays the piper and does the hard cut to tornado>=6.1... but for this package, it would require a coordinated release with notebook and probably other things that carry the great wounds of that fiasco.

@Zsailer
Copy link
Member

Zsailer commented Dec 8, 2020

jupyter_server 1.0.9 has been released and pins tornado>=6.1. Kicked CI here and everything is green! 🎉 Thanks, @bollwyvl!

@Zsailer Zsailer merged commit 27309bc into jupyter:master Dec 8, 2020
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 8, 2020 via email

@Zsailer
Copy link
Member

Zsailer commented Dec 9, 2020

Oops, just released nbclassic 0.2.4 before I saw this.

Yeah, I think it would be a good idea to pin to jupyter_server~=1.0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tests from distributions, or put in-tree, or... ?
2 participants