Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error_on_interrupt trait #224

Merged
merged 5 commits into from
May 3, 2022

Conversation

davidbrochart
Copy link
Member

@davidbrochart davidbrochart marked this pull request as draft April 28, 2022 16:56
@brichet
Copy link

brichet commented Apr 29, 2022

Thanks @davidbrochart, that works fine when timeout on kernel occurred.
As it is useful on timeout reply from kernel only (I think), shouldn't we rename the parameter to error_on_timeout instead of error_on_interrupt ?

@davidbrochart
Copy link
Member Author

It is an execute_reply error that we want to generate when the kernel was interrupted (by us) after an execution timeout, so more precisely it should be error_on_interrupt_on_timeout, but that's a bit long 😄
I'm fine with error_on_timeout too.

@brichet
Copy link

brichet commented Apr 29, 2022

👍

@davidbrochart davidbrochart marked this pull request as ready for review May 3, 2022 07:52
@davidbrochart davidbrochart merged commit 571a65f into jupyter:main May 3, 2022
@davidbrochart davidbrochart deleted the error_on_interrupt branch May 3, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants