Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MultiKernelManager #51

Merged
merged 4 commits into from
May 14, 2020
Merged

Support MultiKernelManager #51

merged 4 commits into from
May 14, 2020

Conversation

davidbrochart
Copy link
Member

@davidbrochart davidbrochart commented May 12, 2020 •
edited
Loading

In order to remove some boilerplate code in Voila, it would be nice if NotebookClient could accept a MultiKernelManager instead of a KernelManager. Their APIs differ, but a MultiKernelManager's underlying KernelManager can be retrieved through the get_kernel(kernel_id) method.
This PR makes (async_)start_new_kernel_client support a MultiKernelManager by checking the presence of a client() method, which only a KernelManager has.

@davidbrochart davidbrochart mentioned this pull request May 12, 2020
Open
@davidbrochart
Copy link
Member Author

Trigger CI.

@davidbrochart davidbrochart reopened this May 12, 2020
MSeal
MSeal suggested changes May 12, 2020
View reviewed changes
Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely needs a unittest for KernelManager and MultiKernelManager patterns, but LGTM otherwise

@davidbrochart
Copy link
Member Author

Trigger CI.

@davidbrochart davidbrochart reopened this May 13, 2020
@davidbrochart davidbrochart merged commit 67c2f28 into jupyter:master May 14, 2020
@davidbrochart davidbrochart deleted the multikernelmanager branch May 14, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSeal MSeal MSeal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbrochart @MSeal