Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reset_kc to setup_kernel #53

Merged
merged 6 commits into from
May 20, 2020
Merged

Adding reset_kc to setup_kernel #53

merged 6 commits into from
May 20, 2020

Conversation

danielfrg
Copy link
Contributor

Matching what async_setup_kernel does.

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a decent idea, thanks for opening a PR. I would like to have a test confirming the new keyword works as expected though.

nbclient/client.py Outdated Show resolved Hide resolved
@danielfrg
Copy link
Contributor Author

danielfrg commented May 14, 2020

I will add a test soon, I edited this directly on GitHub 🙈

Let me know what you prefer in terms of name/functionality.
My opinion: I agree that cleanup_kc is better.

I can also clean up async_setup_kernel as part of this, just let me know.

If you want to maintain the current convention I guess the default should be cleanup_kc =True, thats what happens now without the flag and seams reasonable to be because it's a contextmanager.

@MSeal
Copy link
Contributor

MSeal commented May 15, 2020

@davidbrochart what do you think about changing reset_kc to cleanup_kc?

@davidbrochart
Copy link
Member

Yes it is more coherent to change it to cleanup_kc. It's relatively new so I think we can afford that change.

@danielfrg
Copy link
Contributor Author

I cleaned changed reset_kc to cleanup_kc on the *setup_kernel functions and added a test_cleanup_kernel_client test.

Cleaned up a bit reset_kc on execute.

I think this should make it more coherent.

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MSeal MSeal merged commit a32d6ba into jupyter:master May 20, 2020
@danielfrg danielfrg deleted the patch-1 branch May 20, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants