Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GH actions to test on OSX and Windows as well #63

Merged
merged 13 commits into from
May 22, 2020
Merged

Use GH actions to test on OSX and Windows as well #63

merged 13 commits into from
May 22, 2020

Conversation

davidbrochart
Copy link
Member

No description provided.

@davidbrochart
Copy link
Member Author

Some interesting results: https://github.com/davidbrochart/nbclient/pull/1

@choldgraf
Copy link
Contributor

Haha whoa - I wonder why it isn't running on this PR though?

@davidbrochart
Copy link
Member Author

Yes I don't know why either. And it doesn't run the coverage job.

@choldgraf
Copy link
Contributor

what if you manually set it to on: pull_request, push? Maybe it's the * that is the issue?

@davidbrochart
Copy link
Member Author

Ah it needs the tests to pass before doing code coverage 😄

@davidbrochart
Copy link
Member Author

test_many_parallel_notebooks was failing because it uses multiprocessing (a pool of 2 cores + the main python program). Maybe we only have one core on GH actions?

@davidbrochart
Copy link
Member Author

This is ready to be merged. We are keeping Travis CI anyway, so it's just adding GitHub actions CI, except that we don't use pebble anymore for test_many_parallel_notebooks (for some reason it didn't work on GH actions, and we have the same with concurrent.futures.ProcessPoolExecutor).

@davidbrochart davidbrochart merged commit 6510bd9 into jupyter:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants