Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: A few reST syntactic changes #86

Merged
merged 7 commits into from
Jun 27, 2020
Merged

Conversation

mgeier
Copy link
Contributor

@mgeier mgeier commented Jun 27, 2020

Also enables the "any" role by default, which automatically creates links and -- very importantly -- creates warnings on broken links.

BTW, this also checks for warnings on CircleCI.

@mgeier
Copy link
Contributor Author

mgeier commented Jun 27, 2020

I don't know whether tests.test_client.IPY_MAJOR is needed. The tests seem to pass without it.

If it actually is needed, I'll have to mock IPython more thoroughly or add it to the doc dependencies.

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for improving things

I think the IPY_MAJOR code was a left-over copy-and-paste from nbconvert tests. Looks safe to remove.

@MSeal
Copy link
Contributor

MSeal commented Jun 27, 2020

I'm going to go ahead and merge. If there's more follow-up changes I can review those quickly as well.

@MSeal MSeal merged commit 4314a44 into jupyter:master Jun 27, 2020
@mgeier mgeier deleted the doc-rest-formatting branch June 27, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants