Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share/templates/classic/static/style.css missing on PyPI #1896

Closed
dotlambda opened this issue Oct 28, 2022 · 2 comments · Fixed by #1916
Closed

share/templates/classic/static/style.css missing on PyPI #1896

dotlambda opened this issue Oct 28, 2022 · 2 comments · Fixed by #1916

Comments

@dotlambda
Copy link

dotlambda commented Oct 28, 2022

share/templates/lab/static/index.css, share/templates/lab/static/theme-dark.css, and share/templates/lab/static/theme-light.css were added to the sdist but share/templates/classic/static/style.css was not. That means you need an internet connection to install nbconvert even after downloading the sdist from PyPI.

@dotlambda dotlambda changed the title share/templates/classis/static/style.css missing on PyPI share/templates/classic/static/style.css missing on PyPI Oct 28, 2022
@frenzymadness
Copy link
Contributor

I'm having the same problem trying to update nbconvert package in Fedora. Our build system cannot download anything from internet.

Could you please fix this?

@dotlambda
Copy link
Author

ping @blink1073

blink1073 added a commit that referenced this issue Dec 4, 2022
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Mar 24, 2023
…ar dep)

Obsolete as of jupyter/nbconvert#1896 which includes
the needed CSS.

When poking at this, before discovering the above, I did wonder note we _might_
be able to change jupyter_server's dep on nbconvert to a PDEPEND, but that's not
necessary now, I hope.

For completeness, the circular dep was:
```
(dev-python/jupyter-server-2.4.0:0/0::gentoo, ebuild scheduled for merge) depends on
 (dev-python/nbconvert-7.2.10:0/0::gentoo, ebuild scheduled for merge) (runtime)
  (dev-python/nbclassic-0.5.3-r1:0/0::gentoo, ebuild scheduled for merge) (buildtime)
   (dev-python/notebook_shim-0.2.2-r1:0/0::gentoo, ebuild scheduled for merge) (runtime)
    (dev-python/jupyter-server-2.4.0:0/0::gentoo, ebuild scheduled for merge) (runtime)
```

See also 0d1d3a5 and 2d0a612.

Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants