Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pathed template files to behave correctly for local relative paths without a dot #1381

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Fixed pathed template files to behave correctly for local relative paths without a dot #1381

merged 1 commit into from
Sep 12, 2020

Conversation

MSeal
Copy link
Contributor

@MSeal MSeal commented Sep 12, 2020

Fixes #1347

willingc
willingc approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @MSeal

@MSeal MSeal merged commit 4e3f935 into jupyter:master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@maartenbreddels maartenbreddels Awaiting requested review from maartenbreddels

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CWD seem to have been inadvertently removed from template_path
2 participants
@MSeal @willingc