fix: missing dep on ipython_genutils #1726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
Mar 10, 2022
| @@ -224,7 +224,8 @@ def get_data_files(): | |||
| 'pandocfilters>=1.4.1', | |||
| 'testpath', | |||
| 'defusedxml', | |||
| 'nbclient>=0.5.0,<0.6.0' | |||
| 'nbclient>=0.5.0,<0.6.0', | |||
| 'ipython_genutils', | |||
There was a problem hiding this comment.
Suggested change
| 'ipython_genutils', | |
| 'ipython-genutils', |
Could write it this way instead.
bollwyvl
approved these changes
Mar 10, 2022
|
I dropped ipython_genutils in nbclient, since it was mostly used to handle python2/python3 compatibility. Maybe we can do the same here, instead of depending on it? |
|
mmm it seems it's not only about py2/3 compat here, so maybe it's fine to still depend on it. |
bilke
added a commit
to ufz/ogs
that referenced
this pull request
Mar 11, 2022
Can be removed when nbconvert is fixed: jupyter/nbconvert#1726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1725.
See https://github.com/jupyter/nbconvert/search?q=ipython_genutils for usages.