WebPDFExporter: Emulate media print #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a change I made in #1718 where I wrongly thought that we needed to emulate the "screen" media in order for the background to properly be colored when using a custom theme, but it does not seem to be the case, only the "printBackground" pyppeteer option and the "webkit-print-color-adjust" CSS rules are needed.
The "print" media emulation is needed so that the following CSS rules are properly applied (fixing issues with page breaks on the PDF output): https://github.com/jupyter/nbconvert/blob/main/share/templates/lab/index.html.j2#L117
cc. @mnowacki-b