Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests from bdist #1822

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Conversation

marmitar
Copy link
Contributor

@marmitar marmitar commented Aug 6, 2022

As @wvxvw pointed out in #1819, nbconvert shouldn't be packaging and distributing test files in binary wheels. This PR is a simple solution for that.

@marmitar
Copy link
Contributor Author

marmitar commented Aug 6, 2022

So both failing tests assume the test files are installed with nbconvert. Pip always install a wheel though, even when installing from a sdist, in which case the bdist is built before installing. The only solution for this is installing in editable mode, using the source files directly for that package. This would require changing the Github action test-sdist into

python -m pip install -e ${{inputs.package_spec}}

@marmitar marmitar force-pushed the remove-test-from-bdist branch from fd8a5b1 to f6a0357 Compare August 16, 2022 02:46
@marmitar
Copy link
Contributor Author

Wheel got reduced by 52%.

> ls -h dist/ new/
dist/:
total 1412
564 nbconvert-7.0.0rc3-py3-none-any.whl  848 nbconvert-7.0.0rc3.tar.gz

new/:
total 1116
268 nbconvert-7.0.0rc3-py3-none-any.whl  848 nbconvert-7.0.0rc3.tar.gz
> math \(564 - 268\) / 564
0.524823

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants