Allow pattern in output_base #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure I am able to set PR labels |
|
CI failures seem unrelated to PR changes. |
blink1073
changed the title
|
The link failure is being addressed in #1968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional functionality to the
output_baseconfiguration option (--output) in order to allow patterning of output filenames when converting multiple notebooks at once.Fairly exhaustive tests of the changes are also implemented.
I don't believe this requires changes to the documentation outside what is auto-generated from the doc-strings and descriptions defined in the Python files.
I am using this in my configuration to make the rendered markdown files have an additional marker to distinguish them from manually created markdown files:
See #1966 for more details.
Fix: #1966