Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitetly exclude or include all files in Manifest. #670

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Explicitetly exclude or include all files in Manifest. #670

merged 1 commit into from
Sep 13, 2017

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Sep 6, 2017

And test for it.
Finish up #667

I used the following criteria:

If Internet were to disapear which file would still be relevant?

So I excluded the one that configure services we use.

@mpacer
Copy link
Member

mpacer commented Sep 13, 2017

Looks good to me. Merging.

@mpacer mpacer merged commit 7921a2e into jupyter:master Sep 13, 2017
@mpacer mpacer added this to the 5.4 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Carreau @mpacer