Simplify setup.py #949
Merged
Simplify setup.py #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
takluyver
commented
Jan 31, 2019
takluyver
commented
- We now always import setuptools (while avoiding implicit builds of eggs), so a lot of conditional logic to handle use with and without setuptools can be removed - we only need to handle running with setuptools.
- The long description was read from the README and then replaced by a hardcoded string. It looks like two overlapping PRs added a long description (Release 5.4 #869 and Added long description to setuptools for new pypi page #874). I've kept the README as the long description.
The code just above reads the README
Scripts are now generated from entry points by packaging tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.