Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter server 2.0 compatability fixes #649

Merged
merged 3 commits into from
Jan 15, 2023
Merged

Conversation

vidartf
Copy link
Collaborator

@vidartf vidartf commented Jan 15, 2023

Fixes issues related to missing xsrf values due to our use of navigator.sendBeacon for closing the web tools. Also fixes a deprecation warning for missing identity_provider.

@fperez
Copy link
Member

fperez commented Mar 13, 2023

Quick q @vidartf - are you planning on making an official release with this fix? I'd prefer to deploy from a released package if possible, so I'm curious what your plans are (no pressure, obviously, and very grateful for the fixes, just asking for planning purposes).

@vidartf
Copy link
Collaborator Author

vidartf commented Mar 13, 2023

Release is blocked on #650, not entirely sure when I'll have time for it. Lab already has a similar fix with some import inspection, so if someone else wants to give that a go that would be very much appreciated!

@fperez
Copy link
Member

fperez commented Mar 13, 2023

Understood, no worries. Thanks!!

fperez added a commit to fperez/datahub that referenced this pull request Mar 14, 2023
Currently available nbdime (v3.1.1) is incompatible with jupyter server 2.0. See jupyter/nbdime#649 for more.

Will disable this and revert to an official release once a compatible one becomes available.
shaneknapp pushed a commit to berkeley-dsep-infra/stat159-user-image that referenced this pull request Aug 29, 2024
Currently available nbdime (v3.1.1) is incompatible with jupyter server 2.0. See jupyter/nbdime#649 for more.

Will disable this and revert to an official release once a compatible one becomes available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants