Update files with prettier formatting #668
Conversation
|
Thanks! I left some comments on the config. Additionally it would probably make sense to ignore the package-lock.json file, as it is auto-generated. |
|
@vidartf Sorry for the multiple commit reverts. It is to keep on having all the formatting in a single commit and I forgot to include your suggestion about ignoring the |
| .nbdime-root.jp-mod-hideUnchanged .jp-Diff-addremchunk[data-nbdime-NCellsHiddenBefore]::before { | ||
| content: attr(data-nbdime-NCellsHiddenBefore) " unchanged cell(s) hidden"; | ||
| .nbdime-root.jp-mod-hideUnchanged | ||
| .jp-Cell-diff[data-nbdime-NCellsHiddenBefore]::before, |
There was a problem hiding this comment.
I would prefer it if single CSS rules weren't split across lines (if such a rule config is easily available.
There was a problem hiding this comment.
I have tried to add --print-width=120 in prettier script options in the package.json file but it doesn't seem to produce effect on the width of the lines.
|
Note on git techniques: When we agree on the final config, we can use |
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Some thoughts:
- this (but not the
.prettierignoregrumble grumble) could live inpackage.json#/prettier, avoiding Yet Another File in the root of the repo - if also using
black, settingcolumnWidth: 88is nice, and can often make a difference for long ts signatures - since this will already change a lot of files, adding
proseWrap: always(only applies to markdown) can further tighten up diffs
| import type { | ||
| JupyterFrontEndPlugin, JupyterFrontEnd | ||
| JupyterFrontEndPlugin, |
There was a problem hiding this comment.
adding https://github.com/trivago/prettier-plugin-sort-imports , with a bit of config, can help substantially for big import lists e.g. "first unknown-third-party, then lumino, then lab, then local"
… package.json file.
HaudinFlorence
force-pushed
the
update_files_with_prettier_formatting
branch
from
cd7994f
to
e21a723
Compare
|
Thanks @vidartf for pushing on this PR. Could we do anything more to help you merging this one? |
|
No, I think this PR is ready to go, it is just a question of checking the timing vs other PRs in order to minimize conflict resolution work. |
|
@vidartf I wonder if that would have been easier the other way (first merging the lab 4.0 PR and then applying formatting)? |
Update the .ts, .js, .json, .css and .md files with prettier formatting.