Assignment toolbar #1

jhamrick · 2014-09-15T01:12:59Z

Add javascript and css for the nbgrader toolbar for creating assignments.

takluyver · 2014-09-15T04:34:27Z

@jhamrick it looks like you're not a collaborator on this repo. I've just made an nbgrader team and invited you to join it. You may decide to work through pull requests anyway - that's up to you and @ellisonbg - but it seems right that you should have full access to this repo.

jhamrick · 2014-09-15T05:53:52Z

Awesome, thanks! 😃

Carreau · 2014-09-15T07:06:41Z

Agreed, Jess should at least be admin and have right to add people to nbgrader team. In roughly two days I should be able to help again. For now last rehearsal... :-P

Le 15 sept. 2014 à 07:53, "Jessica B. Hamrick" notifications@github.com a écrit :

Awesome, thanks!

—
Reply to this email directly or view it on GitHub.

ellisonbg · 2014-09-15T15:51:07Z

Great, I will review this today!

ellisonbg · 2014-09-16T05:39:20Z

Here is the metadata @jhamrick and I talked about this celltoolbar setting:

cell.metadata['nbgrader']['solution']=True|False to set that a cell is a solution and should be replaced by a stub in the version sent to students.
cell.metadata['nbgrader']['grade']=True|False indicates that a code or markdown cell will be graded. If this is a code cell, it will usually be autograded, if a markdown cell it will be graded by a human using a Google Form.
cell.metadata['nbgrader']['points']=int how many points should be assigned to that cell for autograding purposes. This MUST be on all code cell with grade=True and MAY be on markdown cell (still thinking about that.

ellisonbg · 2014-09-16T05:49:08Z

One other metadata field:

cell.metadata['nbgrader']['id'] will be a human readable id for each cell with grade=True for display to human graders.

jhamrick · 2014-09-16T06:07:57Z

Ok, this has been update and is ready for review again.

ellisonbg · 2014-09-16T21:47:43Z

nbextensions/nbgrader.js

+     * Add a display class to the cell element, depending on the
+     * nbgrader cell type.
+     */
+    var display_cell_type = function (cell) {


Because cells already have a cell_type attribute in the document format, I find that using that name here is a bit confusing. Originally I was expecting to have two separate boolean attributes solution and grade. Trying to think if you would ever want a cell that was both solution and grade. Actually I think there is one. If you asked the students to write the tests themselves. Then you would want both to stub the cell in the student version, but still autograde it later. Based on this, I think we should use metadata.nbgrader.solution=true/false and metadata.nbgrader.grade=true|false. Then the UI for each would be a checkbox. Does this make sense?

Ah, yes, good point -- I'll change it to be this way. I think I must have been too tired when I was working on this last night as I totally missed that you had it that way in your comment!

jhamrick · 2014-09-17T00:06:02Z

Ok, I think I addressed all your comments. I went with grader_id for the cell id but can just as easily change it to something else, too.

jhamrick · 2014-09-17T00:10:41Z

One thing I realized though is that having the solution checkbox is a little confusing -- for cells that use the comment syntax, should the solution checkbox be checked? Currently (based on this PR and the other one) I think the behavior is that if solution == True, the contents of the entire cell will be replaced with the stub. However, it feels natural (at least to me) to also check the solution checkbox for cells that use the comment syntax -- but in those cases I don't want to replace the entire contents of the cell.

Perhaps we could do something where if there is the comment syntax, then only the subregion of the cell is replaced -- even if solution == True (and so in those cases the entire cell contents would not be replaced).

jhamrick · 2014-09-17T01:23:54Z

Hmm, this is actually reeeeallly slow to load for long notebooks (I have one notebook for which it actually times out). This seems problematic enough that I want to fiddle with it a bit before this is merged.

jhamrick · 2014-09-17T02:52:19Z

Ok, done fiddling. The issue was in how I was loading it in my custom.js; I've modified the instructions at the top of nbgrader.js accordingly.

jhamrick · 2014-09-23T20:11:20Z

Build is failing here because .travis.yml doesn't exist yet.

Carreau · 2014-09-26T09:31:29Z

nbextensions/nbgrader.js

+        } else {
+            return cell.metadata.nbgrader.grade;
+        }
+    };


This would be usefull : https://github.com/letsgetrandy/brototype#features :-)

Eh. Yes, but it would only be used in two places so I'm not sure I want to include a dependency just for that.

Carreau · 2014-09-26T09:40:19Z

Looks good, a few suggestions inline. s/ipython/jupyter/g.

jhamrick · 2014-09-26T19:01:32Z

You mean the ipython in load_ipython_extension? At least for the moment, that is a special name used by IPython.load_extensions, so that has to stay.

Carreau · 2014-09-26T19:11:01Z

You mean the ipython in load_ipython_extension? At least for the moment, that is a special name used by IPython.load_extensions, so that has to stay.

Yep, that was a comment for the future :-) I should have added a :-) or a :-P.

jhamrick · 2014-09-26T19:18:17Z

Ah, ok :-)

And yeah, bootstrap might be a good idea given that ipython is already using it anyway. I'll play with it a bit...

jhamrick · 2014-09-26T19:52:44Z

Seems like bootstrap doesn't play all that nicely with how the celltoolbar is styled by default, so I'm going to leave it for now.

Carreau · 2014-09-26T19:54:00Z

nbextensions/nbgrader.js

+        link.type = 'text/css';
+        link.rel = 'stylesheet';
+        link.href = require.toUrl('./nbgrader.css');
+        console.log(link);


Good catch!

jhamrick · 2014-10-01T21:17:02Z

@ellisonbg I think this is ready for merge -- do you want to do another review of this or should I just go ahead and merge it?

ellisonbg · 2014-10-08T23:40:45Z

nbextensions/nbgrader.js

+        text.addClass('nbgrader-id-input');
+        text.attr("value", cell.metadata.nbgrader.grader_id);
+        text.keyup(function () {
+            cell.metadata.nbgrader.grader_id = text.val();


I have been using a grader_id in the context of peer grading, where there it is a uuid assigned to a person who is peer grading. Maybe grade_id instead in this context?

ellisonbg · 2014-10-08T23:42:12Z

OK, digging out of everything now...this looks awesome! I just tried it out and it works really well. Other than the one comment I just made about grader_id -> grade_id it is ready to go. I can also just merge and we can fix that in a later PR if you want.

jhamrick · 2014-10-09T01:25:55Z

I'll go ahead and change it now, it's not too much trouble to do that.

Assignment toolbar

ellisonbg · 2014-10-09T03:46:52Z

thanks, great work!

On Wed, Oct 8, 2014 at 6:27 PM, Jessica B. Hamrick <notifications@github.com

wrote:

Merged #1 #1.

—
Reply to this email directly or view it on GitHub
#1 (comment).

Brian E. Granger
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com

Test HubAuth

Changing environment for validation

Update docs

ellisonbg mentioned this pull request Sep 16, 2014

Split assignment preprocessor into multiple preprocessors #3

Merged

ellisonbg reviewed Sep 16, 2014
View reviewed changes

Carreau reviewed Sep 26, 2014
View reviewed changes

jhamrick added 5 commits September 26, 2014 12:33

Add nbgrader create assignment extension

9a67fa9

Add example notebook to test toolbar

78dec0c

Ignore ipython checkpoints

77ef176

Rename "autograder" cells to "test" cells

7832726

Update toolbar to only have 'solution' and 'grade' cells

d5343dc

Fix styling for points textbox

5cb83c8

jhamrick force-pushed the assignment-toolbar branch from 2fc96c9 to 5cb83c8 Compare September 26, 2014 19:33

Carreau reviewed Sep 26, 2014
View reviewed changes

jhamrick added 2 commits September 26, 2014 13:03

Remove debug statement

0b58f94

Rename load_ipython_extension to load_extension

1c5d61a

jhamrick added enhancement needs review labels Sep 26, 2014

jhamrick mentioned this pull request Oct 1, 2014

Updated readme #11

Closed

jhamrick mentioned this pull request Oct 1, 2014

Add docs #8

Closed

ellisonbg reviewed Oct 8, 2014
View reviewed changes

Rename grader_id to grade_id

56929b2

jhamrick added a commit that referenced this pull request Oct 9, 2014

Merge pull request #1 from jhamrick/assignment-toolbar

6fc0bce

Assignment toolbar

jhamrick merged commit 6fc0bce into jupyter:master Oct 9, 2014

jhamrick deleted the assignment-toolbar branch October 9, 2014 01:27

jdfreder added a commit that referenced this pull request Mar 25, 2015

Merge pull request #1 from jhamrick/test-hubauth

18161a3

Test HubAuth

jhamrick modified the milestone: 1.0 Apr 1, 2015

choldgraf mentioned this pull request Jan 18, 2017

Allow autograding to skip usage of the database #661

Closed

ryanlovett added a commit to ryanlovett/nbgrader that referenced this pull request Feb 20, 2018

Merge pull request jupyter#1 from berkeley-dsep-infra/validator_changes

e48d20c

Changing environment for validation

willingc pushed a commit that referenced this pull request May 12, 2020

Merge pull request #1 from lzach/update_docs

fe3ef73

Update docs

OptimusPrimus mentioned this pull request Oct 18, 2020

jinja2.exceptions.TemplateNotFound: formgrade #1382

Closed

divingeek mentioned this pull request Nov 7, 2020

'Connection refused' on second network interface #1366

Open

WolfgangFahl mentioned this pull request Jul 8, 2022

Show more details for Validation errors #1629

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assignment toolbar #1

Assignment toolbar #1

jhamrick commented Sep 15, 2014

takluyver commented Sep 15, 2014

jhamrick commented Sep 15, 2014

Carreau commented Sep 15, 2014

ellisonbg commented Sep 15, 2014

ellisonbg commented Sep 16, 2014

ellisonbg commented Sep 16, 2014

jhamrick commented Sep 16, 2014

ellisonbg Sep 16, 2014

jhamrick Sep 16, 2014

jhamrick commented Sep 17, 2014

jhamrick commented Sep 17, 2014

jhamrick commented Sep 17, 2014

jhamrick commented Sep 17, 2014

jhamrick commented Sep 23, 2014

Carreau Sep 26, 2014

jhamrick Sep 26, 2014

Carreau commented Sep 26, 2014

jhamrick commented Sep 26, 2014

Carreau commented Sep 26, 2014

jhamrick commented Sep 26, 2014

jhamrick commented Sep 26, 2014

Carreau Sep 26, 2014

jhamrick Sep 26, 2014

jhamrick commented Oct 1, 2014

ellisonbg Oct 8, 2014

ellisonbg commented Oct 8, 2014

jhamrick commented Oct 9, 2014

ellisonbg commented Oct 9, 2014

Assignment toolbar #1

Assignment toolbar #1

Conversation

jhamrick commented Sep 15, 2014

takluyver commented Sep 15, 2014

jhamrick commented Sep 15, 2014

Carreau commented Sep 15, 2014

ellisonbg commented Sep 15, 2014

ellisonbg commented Sep 16, 2014

ellisonbg commented Sep 16, 2014

jhamrick commented Sep 16, 2014

ellisonbg Sep 16, 2014

Choose a reason for hiding this comment

jhamrick Sep 16, 2014

Choose a reason for hiding this comment

jhamrick commented Sep 17, 2014

jhamrick commented Sep 17, 2014

jhamrick commented Sep 17, 2014

jhamrick commented Sep 17, 2014

jhamrick commented Sep 23, 2014

Carreau Sep 26, 2014

Choose a reason for hiding this comment

jhamrick Sep 26, 2014

Choose a reason for hiding this comment

Carreau commented Sep 26, 2014

jhamrick commented Sep 26, 2014

Carreau commented Sep 26, 2014

jhamrick commented Sep 26, 2014

jhamrick commented Sep 26, 2014

Carreau Sep 26, 2014

Choose a reason for hiding this comment

jhamrick Sep 26, 2014

Choose a reason for hiding this comment

jhamrick commented Oct 1, 2014

ellisonbg Oct 8, 2014

Choose a reason for hiding this comment

ellisonbg commented Oct 8, 2014

jhamrick commented Oct 9, 2014

ellisonbg commented Oct 9, 2014