Upgrade nbconvert #1567
Merged
Upgrade nbconvert #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 3, 2022 11:09
…to remove 'execution' part of cell metadata which does not allow comparison between Notebook files after execution
…re but use the one from nbclient, checking the execute_reply after execution
… of template_file
|
Thanks for this PR @brichet |
added 2 commits
May 3, 2022 16:31
… browser to english language to be able to reach menu item by 'data-name' and (2) changes the way date are inserted in form to avoid error on date format
|
@BertR I made some changes to fix nbextensions errors, and also to avoid errors with date format and language in test browser (my locales are not English, so some tests were failing). |
|
Great stuff! |
This was referenced May 4, 2022
Closed
|
Thanks @BertR |
|
Does this supersede #1421? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades dependencies to
nbconvert>=6,andjinja2>=3.nbclientmethod (instead of overriding thenbconvert<6one)feedbackandformgradetemplates are now using thenbconvert>6template systemClearMetadataPreprocessorinexporterwhen running tests to remove the newexecutionwhich which was breaking comparison testsCloses #1373, #1382
Thanks @davidbrochart for nbclient adaptation