Compatibility with Notebook7 and jupyterLab4 #1684
Conversation
|
|
brichet
force-pushed
the
jlab4_nb7
branch
2 times, most recently
from
7282210
to
067c39f
Compare
brichet
force-pushed
the
jlab4_nb7
branch
2 times, most recently
from
fc2a8e5
to
76a4fda
Compare
|
Is there any reason not to remove |
|
JupyterLab 4 final is now released, and Notebook 7 beta is available. Maybe this PR could be resumed? |
Sure, I was waiting for some opinions about #1749 first, but in any case, I should have time to work on it in the next few weeks. |
There is no reason, except that I want to clean properly everything related to nbextensions (not only the tests). |
| tmpPath: tempPath, | ||
| mockSettings: { | ||
| '@jupyterlab/apputils-extension:notification': { | ||
| fetchNews: 'false' |
There was a problem hiding this comment.
Quick heads-up there were some updates on this config in core JupyterLab in jupyterlab/jupyterlab#14609.
We can check whether the default mockSettings from JupyterLab is already automatically applied, if we should add checkForUpdates: false as well.
brichet
force-pushed
the
jlab4_nb7
branch
5 times, most recently
from
5be5848
to
1bf8f6a
Compare
…of Cell widget, and to simplify the listeners
…ecommand in Notebook
|
Thanks @brichet for working on this 👍 Diff looks good at first glance. Do you think it would be ready to be merged so it can be tested in a |
|
Thanks @jtpio for looking at it. |
|
Sounds good, thanks! |
* Update dependencies to jupyterlab>=4, fix menu entries and fix mathjax error * Includes assignment-list, course-list and formgrader extensions as main panel tab * Remove required dependency to LabShell * Make it work with Notebook7 and JupyterLab4 * update dependencies * Refactore create_assignment_extension to depend on CellModel instead of Cell widget, and to simplify the listeners * Update the tests according to the updates of JupyterLab * Reintegrate the cellPrompt in create assignment cell widget * Activate by default the new created tab in Notebook (assignment list, course list and formgrader) * add test for extensions in notebook * Fix docs tests and insert nbextensions test in UI-tests * Update dependencies to jupyterlab-4.0.0a32 and notebook-7.0.0a10 * Downgrade dependency to Notebook as it breaks installation * bump to Notebook-7.0.0a10 * update dependencies * Refactor the extensions for a better managment of the menu and palettecommand in Notebook * Update to Jlab 4.0.0a34 and Notebook 7.0.0a13 * Open the existing Formgrader tab if already loaded from courses list tab * fix UI tests * Removal of python 3.7 support and integration of python 3.11 in tests * Update actions and node version in tests * Update to jupyterlab 4.0.0a37 and notebook 7.0.0a17 * Fix before-build-npm * Includes jupyter#1756 * Remove nbextensions and related code * Update dependencies to lab 4 released and notebook 7b.4 * Add the playwright report as artifact
This PR brings compatibility to Notebook7 and JupyterLab4, both not yet released.
In Notebook7 the formgrader; assignment list and course list are opened in a tab in the
treeview, while the notebook files and feedbacks are opened in a new browser tab.Remains to be fixed:
Notebook<7, this is opening a new browser tab with a tree view. In this version, it changes the current path in file browser tab. Unfortunately, it does not activate the file browser tab, which makes it look like nothing is happening.EDIT: fixed in Fix HTML viewer notebook#6583
Fell free to try it and discuss about expected behaviors.