Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check marking schemes for attachments to prevent leakage #1783

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

tuncbkose
Copy link
Contributor

@tuncbkose tuncbkose commented May 8, 2023

Fixes #1782. The problem of adding images to marking schemes remains unsolved.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Binder 👈 Launch a Binder on branch AaltoSciComp/nbgrader/attachment_leakage

@tuncbkose tuncbkose marked this pull request as ready for review May 10, 2023 07:17
@tuncbkose tuncbkose changed the title [WIP] Check marking schemes for attachments to prevent leakage Check marking schemes for attachments to prevent leakage May 10, 2023
Copy link
Contributor

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tuncbkose

nbgrader/preprocessors/clearmarkingscheme.py Outdated Show resolved Hide resolved
nbgrader/preprocessors/clearmarkingscheme.py Show resolved Hide resolved
@tuncbkose
Copy link
Contributor Author

Not sure why the docs have failed

@tuncbkose tuncbkose requested a review from brichet June 16, 2023 07:00
@brichet
Copy link
Contributor

brichet commented Jun 16, 2023

Not sure why the docs have failed

Seems to be related to sphinx_rtd_theme not compatible with Sphinx>=7. I'm testing it locally and I'll fix it.
I don't know why this only happened yesterday.

EDIT: I opened #1791

Comment on lines +130 to +148
### BEGIN MARK SCHEME
Text text text text text.
![](attachment:image1.jpg)
Grade grade grade.
![](attachment:image2.png)
Mark mark mark mark.
### END MARK SCHEME
Copy link
Contributor

@brichet brichet Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### BEGIN MARK SCHEME
Text text text text text.
![](attachment:image1.jpg)
Grade grade grade.
![](attachment:image2.png)
Mark mark mark mark.
### END MARK SCHEME
### BEGIN MARK SCHEME
Text text text text text.
![alternative text](attachment:image1.jpg)
Grade grade grade.
### END MARK SCHEME

Thanks @tuncbkose, I was more thinking about alternative text to the image, to test the regular expression.
But if you think it is relevant to keep also a test with 2 images inserted we can also keep it (maybe keeping text around is also a good thing)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. I'll add one with an alternative text. As for this example with two attachments and text around them, I don't think it matters too much but it doesn't hurt to keep it.

@brichet
Copy link
Contributor

brichet commented Jun 16, 2023

Failures are not related.

Thanks @tuncbkose

@brichet brichet merged commit 97160b4 into jupyter:main Jun 16, 2023
@tuncbkose tuncbkose deleted the attachment_leakage branch July 13, 2023 06:15
AlirezaT99 pushed a commit to AaltoSciComp/nbgrader that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attachment leakage in generated notebooks
2 participants