Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix labextension plugin IDs in the docs and demos #1927

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix labextension plugin IDs in the docs and demos #1927

merged 1 commit into from
Oct 4, 2024

Conversation

lahwaacz
Copy link
Contributor

#1811 has happened again 🤦

This fixes #1893

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch lahwaacz/nbgrader/fix-docs

@brichet
Copy link
Contributor

brichet commented Oct 1, 2024

#1811 has happened again 🤦

This fixes #1893

Thanks @lahwaacz, my fault again.

Test failures are not related, but let fix them before (I'll do it) and rebase.

@brichet
Copy link
Contributor

brichet commented Oct 1, 2024

Fixes #1921

@brichet
Copy link
Contributor

brichet commented Oct 1, 2024

@lahwaacz can you rebase after #1928 ?

@brichet brichet mentioned this pull request Oct 1, 2024
Closed
@lahwaacz
Copy link
Contributor Author

lahwaacz commented Oct 1, 2024

@lahwaacz can you rebase after #1928 ?

Done

brichet
brichet approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lahwaacz

@brichet brichet merged commit b786ea6 into jupyter:main Oct 4, 2024
24 checks passed
@brichet brichet linked an issue Oct 4, 2024 that may be closed by this pull request
Fix documentation on enabling and disabling labextensions #1921
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brichet brichet brichet approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix documentation on enabling and disabling labextensions
2 participants
@lahwaacz @brichet