Skip to content

Commit

Permalink
Merge pull request #3497 from takluyver/i3496
Browse files Browse the repository at this point in the history
Prevent default event handling on new terminal
  • Loading branch information
takluyver authored Apr 9, 2018
2 parents e3ee807 + 3980d81 commit 87d010b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion notebook/static/tree/js/terminallist.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ define([
$('#new-terminal').click($.proxy(this.new_terminal, this));
};

TerminalList.prototype.new_terminal = function () {
TerminalList.prototype.new_terminal = function (event) {
if (event) {
event.preventDefault();
}
var w = window.open('#', IPython._target);
var base_url = this.base_url;
var settings = {
Expand Down

0 comments on commit 87d010b

Please sign in to comment.