Skip to content

Commit

Permalink
set page_config in initalize_handlers
Browse files Browse the repository at this point in the history
  • Loading branch information
andrii-i committed Jun 8, 2023
1 parent 1d02d06 commit 936f647
Showing 1 changed file with 14 additions and 13 deletions.
27 changes: 14 additions & 13 deletions notebook/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ def get_page_config(self):
api_token = os.getenv("JUPYTERHUB_API_TOKEN", "")
page_config["token"] = api_token

nbclassic_enabled = self.server_extension_is_enabled("nbclassic")
page_config["nbclassic_enabled"] = nbclassic_enabled

server_root = self.settings.get("server_root_dir", "")
server_root = server_root.replace(os.sep, "/")
server_root = os.path.normpath(os.path.expanduser(server_root))
Expand Down Expand Up @@ -116,16 +113,6 @@ def get_page_config(self):
)
return page_config

def server_extension_is_enabled(self, extension):
"""Check if server extension is enabled."""
try:
extension_enabled = (
self.extensionapp.serverapp.extension_manager.extensions[extension].enabled is True
)
except (AttributeError, KeyError, TypeError):
extension_enabled = False
return extension_enabled


class RedirectHandler(NotebookBaseHandler):
"""A redirect handler."""
Expand Down Expand Up @@ -274,8 +261,22 @@ def _default_user_settings_dir(self):
def _default_workspaces_dir(self):
return get_workspaces_dir()

def server_extension_is_enabled(self, extension):
"""Check if server extension is enabled."""
try:
extension_enabled = (
self.serverapp.extension_manager.extensions[extension].enabled is True
)
except (AttributeError, KeyError, TypeError):
extension_enabled = False
return extension_enabled

def initialize_handlers(self):
"""Initialize handlers."""
page_config = self.serverapp.web_app.settings.setdefault("page_config_data", {})
nbclassic_enabled = self.server_extension_is_enabled("nbclassic")
page_config["nbclassic_enabled"] = nbclassic_enabled

self.handlers.append(
(
rf"/{self.file_url_prefix}/((?!.*\.ipynb($|\?)).*)",
Expand Down

0 comments on commit 936f647

Please sign in to comment.