Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove utils functions existing in codemirror. #245

Closed
Carreau opened this issue Jul 30, 2015 · 2 comments · Fixed by #427
Closed

Remove utils functions existing in codemirror. #245

Carreau opened this issue Jul 30, 2015 · 2 comments · Fixed by #427
Assignees
@Carreau
Labels
status:resolved-locked
Milestone
4.1

Comments

@Carreau
Copy link
Member

Carreau commented Jul 30, 2015

These two utils functions seem to exist in codemirror

I guess they are more reliable.
@takluyver
Copy link
Member

Because the line numbers on master are liable to change: the functions in our code are {to,from}_absolute_cursor_position, and in CodeMirror, posFromIndex and indexFromPos. +1 to removing ours if we can.

@minrk
Copy link
Member

minrk commented Jul 30, 2015

👍 to removing our own implementations if they are redundant.

@minrk minrk added this to the 4.1 milestone Sep 11, 2015
@Carreau Carreau self-assigned this Sep 14, 2015
Carreau added a commit to Carreau/jupyter_notebook that referenced this issue Sep 14, 2015
@Carreau
Deprecate duplicate functions from utils.
5fadb67 
Closes jupyter#245
@Carreau Carreau mentioned this issue Sep 14, 2015
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Carreau Carreau

Labels
status:resolved-locked
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

Deprecate duplicate functions from utils. Carreau/jupyter_notebook
3 participants
@minrk @takluyver @Carreau