Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using PageUp/PageDown in Completer, codemirror mistakenly uses goPageUp/goPageDown. #2518

Closed
michael-wise opened this issue May 25, 2017 · 5 comments · Fixed by #3500
Closed

Comments

@michael-wise
Copy link

michael-wise commented May 25, 2017

When viewing code hints (dropdown list of available methods/attributes) for an object, if I navigate the list using page down (instead of arrow keys), it navigates the list as desired, but has the undesired side effect of also moving the text cursor down the page (as if you'd pressed page down while not using code hints). Resultingly, after you press enter to confirm your attribute, the cursor is one page below the line you were just working on.

Here is the commit that added the page-up and page-down functionality to the completer dropdown. fe37c14

Python 3.5.2 |Anaconda 4.2.0 (64-bit)| (default, Jul 5 2016, 11:41:13) [MSC v.1900 64 bit (AMD64)]
IPython 5.1.0 -- An enhanced Interactive Python.
Jupyter Notebook Server 4.2.3.

@takluyver
Copy link
Member

@gnestor have you got time to look into this?

@gnestor
Copy link
Contributor

gnestor commented Jun 22, 2017

@takluyver Sorry for the delay, but sure.

@michael-wise What do you propose? Would it be better if page-up/page-down functionality were removed?

@takluyver
Copy link
Member

If feasible, I think the ideal would be for page-up/page-down to move the text cursor when not completing, and navigate through completions without affecting the text cursor when the completer is open.

If that's tricky, then let's get a simpler fix in for 5.1 (e.g. disable page-up/page-down in the completer.)

@gnestor gnestor added this to the 5.2 milestone Aug 6, 2017
@gnestor gnestor modified the milestones: 5.2, 5.3 Oct 9, 2017
@gnestor gnestor modified the milestones: 5.3, 5.4 Jan 5, 2018
@takluyver takluyver modified the milestones: 5.4, 5.5 Jan 27, 2018
@takluyver takluyver modified the milestones: 5.5, 6.0 Mar 28, 2018
@takluyver
Copy link
Member

@gnestor I've bumped this yet again so I can start moving towards a 5.5 release, but if you do get time to have a look at it, we can un-bump it again.

@gnestor
Copy link
Contributor

gnestor commented Apr 5, 2018

@takluyver I just submitted a potential fix. It seems to work for me using FN+UP and FN+DOWN on a Mac.

@takluyver takluyver modified the milestones: 6.0, 5.5 Apr 19, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants