-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using PageUp/PageDown in Completer, codemirror mistakenly uses goPageUp/goPageDown. #2518
Comments
@gnestor have you got time to look into this? |
@takluyver Sorry for the delay, but sure. @michael-wise What do you propose? Would it be better if page-up/page-down functionality were removed? |
If feasible, I think the ideal would be for page-up/page-down to move the text cursor when not completing, and navigate through completions without affecting the text cursor when the completer is open. If that's tricky, then let's get a simpler fix in for 5.1 (e.g. disable page-up/page-down in the completer.) |
@gnestor I've bumped this yet again so I can start moving towards a 5.5 release, but if you do get time to have a look at it, we can un-bump it again. |
@takluyver I just submitted a potential fix. It seems to work for me using FN+UP and FN+DOWN on a Mac. |
When viewing code hints (dropdown list of available methods/attributes) for an object, if I navigate the list using page down (instead of arrow keys), it navigates the list as desired, but has the undesired side effect of also moving the text cursor down the page (as if you'd pressed page down while not using code hints). Resultingly, after you press enter to confirm your attribute, the cursor is one page below the line you were just working on.
Here is the commit that added the page-up and page-down functionality to the completer dropdown. fe37c14
The text was updated successfully, but these errors were encountered: