Skip to content

Prevent default on pageup/pagedown when completer is active #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2018
Merged

Prevent default on pageup/pagedown when completer is active #3500

merged 1 commit into from
Apr 19, 2018

Conversation

gnestor
Copy link
Contributor

@gnestor gnestor commented Apr 5, 2018

Closes #2518

@gnestor gnestor added this to the 5.5 milestone Apr 5, 2018
@takluyver
Copy link
Member

Just got round to testing this, and it works :-)

@takluyver takluyver merged commit fc24f31 into jupyter:master Apr 19, 2018
@gnestor gnestor deleted the issue-2518 branch April 19, 2018 17:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
5.5
Development

Successfully merging this pull request may close these issues.

When using PageUp/PageDown in Completer, codemirror mistakenly uses goPageUp/goPageDown.
2 participants
@gnestor @takluyver