Issue with docs for running a public notebook server

[lcapelluto]

https://jupyter-notebook.readthedocs.io/en/stable/public_server.html#running-a-public-notebook-server

In summary: On the above page in the docs, replace * with 0.0.0.0.

In detail:
On the above page, it recommends adding this line to your jupyter config:

c.NotebookApp.ip = '*'

to run a notebook server which can be accessed remotely. These docs are on stable and also on the docs for jupyter 4.x. When I tried that with version 4.4, I got an error:

File "/home/forest/.virtualenvs/venv/lib/python3.6/site-packages/traitlets/traitlets.py", line 528, in get
    value = obj._trait_values[self.name]
KeyError: 'allow_remote_access'

The correct option is:

c.NotebookApp.ip = '0.0.0.0'

After that, I was able to run a public server. I think the '*' option was mixed up with this:

c.NotebookApp.allow_origin = '*'

See: https://jupyter-notebook.readthedocs.io/en/stable/config.html

[kevin-bates]

Although your version info looks more like jupyter-core than notebook, I suspect your issue is addressed by #4139.

[lcapelluto]

That's great. Perhaps the documentation could still be updated to save time for users such as myself. If not, feel free to close this issue.

[alfonsomhc]

I run into the same problem and was going to suggest as well that documentation is updated :)