Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Travis/Appveyor #5909

Closed
bollwyvl opened this issue Dec 12, 2020 · 4 comments
Closed

Drop Travis/Appveyor #5909

bollwyvl opened this issue Dec 12, 2020 · 4 comments

Comments

@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 12, 2020

The delays on travis are getting me down on #5907. And appveyor is... appveyor.

It's probably a relatively quick PR to get GitHub Actions spun up and get results faster, and increase platform coverage. Anybody violently against?

Update: taking a look here: bollwyvl#1

@bollwyvl
Copy link
Contributor Author

In exploring this, terminals fail on win/39:

andfoy/pywinpty#134

@bollwyvl
Copy link
Contributor Author

Have all of the python tests running on 3.6-3.9 + pypy:

https://github.com/bollwyvl/notebook/actions/runs/417927458

  • some skips for pypy
  • ignore terminals on py39

@minrk
Copy link
Member

minrk commented Dec 15, 2020

We've been busy migrating ~everything on JupyterHub to GHA and been super happy with it. Migrating from Travis hasn't been too tough in most cases. Feel free to open that PR!

@Zsailer
Copy link
Member

Zsailer commented Jan 13, 2021

Done in #5938.

Looks like terminals on Windows and Python 3.9 are still an issue, but the rest of the tests appear to be running okay 👍

@Zsailer Zsailer closed this as completed Jan 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants