-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not apply asyncio patch for tornado >=6.1 #5907
Conversation
Also, incidentally: can you think of any other places we had to do this stuff? I think i hit most of them... |
I did a search and it looks like:
|
I'm okay! Super busy and spread a little thin, but trying to keep up. How are you? :) |
Same... it'll be great when all the stuff that's in the air lands, but it does seem like a lot right now! |
Looking back at tornado docs, I think we should still be using the selector loop all the time. Performance will be better, as ~everything we do is built add/remove_reader, which are slower when proactor is used do to the extra thread. |
Tornado 6.1 now no longer requires the asyncio patch on windows for python >=3.8. 🎉
On jupyter-server/jupyter_server#339, we went with a hard cut to require 6.1, and remove the patch, but this PR applies the lighter touch from ipython/ipykernel#564 of just not applying the patch.
Fixing this is good, as the error manifests itself as unkillable python hang on windows, timing out CI.