Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't patch event loop for tornado 6.1+ #142

Merged
merged 3 commits into from
Dec 16, 2020

Conversation

bollwyvl
Copy link
Contributor

tornado 6.1 works with the default event loops on all platforms now. I've been working on rooting it out of other repos, still a couple more to do.

As "the future," and having an imminent major version bump, the jupyter_server PR requires tornado 6.1

As this package is already widely deployed, this uses the "just check the tornado version" approach:

Would happily do that, here, if we don't mind pining to the "bleeding edge" tornado, and remove some cruft.

@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #142 (7b37be2) into master (52a9118) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   74.81%   74.44%   -0.38%     
==========================================
  Files          21       21              
  Lines        1608     1608              
==========================================
- Hits         1203     1197       -6     
- Misses        405      411       +6     
Impacted Files Coverage Δ
jupyterlab_server/tests/utils.py 45.65% <100.00%> (-13.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a9118...68407fd. Read the comment docs.

@bollwyvl bollwyvl force-pushed the fix-tornado-asyncio-win-patch branch from e190a17 to 7b37be2 Compare December 16, 2020 02:14
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit d8cfb92 into jupyterlab:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants