don't patch event loop for tornado 6.1+ #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tornado 6.1 works with the default event loops on all platforms now. I've been working on rooting it out of other repos, still a couple more to do.
As "the future," and having an imminent major version bump, the
jupyter_server
PR requires tornado 6.1As this package is already widely deployed, this uses the "just check the tornado version" approach:
Would happily do that, here, if we don't mind pining to the "bleeding edge" tornado, and remove some cruft.