Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu View → Table of Contents should toggle #7147

Closed
Tracked by #3
parmentelat opened this issue Nov 10, 2023 · 5 comments · Fixed by #7178
Closed
Tracked by #3

Menu View → Table of Contents should toggle #7147

parmentelat opened this issue Nov 10, 2023 · 5 comments · Fixed by #7178
Labels

Comments

@parmentelat
Copy link
Contributor

Description

not sure whether it's a bug or a usability issue, but:

  • clicking once in the menu ViewTable of Contents does show the TOC
  • but clicking a second time does not hide the TOC

and btw same goes for ViewDebugger Panel

Reproduce

use the menu entry twice

Expected behavior

I'd expect these 2 functions to behave as togglers, just like how the Show Header thing behaves;
otherwise newby users can only regain their real estate by reloading the page

Context

  • Operating System and version: seen on macos and linux
  • Browser and version: chrome 118
  • Jupyter Notebook version:
jupyter --version
Selected Jupyter core packages...
IPython          : 8.17.2
ipykernel        : 6.26.0
ipywidgets       : not installed
jupyter_client   : 8.5.0
jupyter_core     : 5.5.0
jupyter_server   : 2.9.1
jupyterlab       : 4.0.7
nbclient         : 0.8.0
nbconvert        : 7.10.0
nbformat         : 5.9.2
notebook         : 7.0.6
qtconsole        : not installed
traitlets        : 5.13.0

no output in the browser console

@parmentelat
Copy link
Contributor Author

PS: i just realized - a couple hours later - that the TOC pane has a small closing cross in the upper right corner
not very conspicuous, I must say
I'd rather if the menu acted as a toggle, just like Show Header does
but maybe that's good enough like that...

@RRosio RRosio added enhancement bug and removed status:Needs Triage Applied to issues that need triage bug enhancement labels Nov 14, 2023
@RRosio
Copy link
Collaborator

RRosio commented Nov 14, 2023

Thank you @parmentelat for opening this issue. After inspecting the file browser option from the view menu and noting that it behaves as you suggest (toggle open/close). Leaving this as a bug! If you would like to contribute to this, please feel free to do so!

@cccindyyyl
Copy link
Contributor

Hi @RRosio ! I have some experience with front-end development, and I have successfully reproduced the bug on my end. Would it be possible for me to work on this issue? Thanks!

@RRosio
Copy link
Collaborator

RRosio commented Nov 27, 2023

Hi @cccindyyyl! Yes, there is no need to ask, please feel free to work on this or any issue that you would like to contribute!

@cccindyyyl
Copy link
Contributor

@RRosio Hi! We submitted a pull request #7178 that fixes the issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants