Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too many items in the menus #3

Closed
26 of 28 tasks
parmentelat opened this issue Nov 2, 2023 · 5 comments
Closed
26 of 28 tasks

too many items in the menus #3

parmentelat opened this issue Nov 2, 2023 · 5 comments

Comments

@parmentelat
Copy link
Owner

parmentelat commented Nov 2, 2023

the following submenus / buttons are too wide and need to be disabled

in File jp-mainmenu-file

  • New submenu altogether jp-mainmenu-file-new
  • Rename...

in View jp-mainmenu-view

  • Activate command Palette - it would still be available through a keyboard shortcut, but no need in the menu
  • Open JupyterLab
  • File Browser
  • Toggle Zen Mode because it removes the possibility to undo it (remember the palette is not readily available)
  • Show Notifications
  • Open in JupyterLab
  • ? Open in NbClassic - see below
  • Render Side-by-Side
  • Text Editor Syntax Highlighting
  • ? I think I'll keep Right Sidebar and Left Sidebar but that's arguable

in Settings jp-mainmenu-settings

  • all 5 Text Editor entries
    • Text Editor Indentation
    • Auto Close Brackets
    • Increase Text Editor Font Size
    • Decrease Text Editor Font Size
    • Text Editor Theme
  • all 3 Terminal entries
    • Increase Terminal Font Size
    • Decrease Terminal Font Size
    • Terminal Theme
  • Save Widget State Automatically
    • would just need to disable the @jupyter-widgets/jupyterlab-manager:plugin extension
    • keeping it for now as it is harmless

in Help jp-mainmenu-help

  • Launch Jupyter Notebook File Browser

side notes:

@parmentelat
Copy link
Owner Author

concerning ViewOpen as NbClassic, this could be a simple way to open the notebook in a more friendly layout - no side decoration

however I wonder about possible side-efffects
I suspect the 2 open views (one in FUN, one in the standalone tab) are writing the same file without coordination
this needs to be tested more

@parmentelat
Copy link
Owner Author

parmentelat commented Nov 9, 2023

about scrubbing the remaining menu entries, see:

https://discourse.jupyter.org/t/is-there-a-way-to-introspect-the-mainmenu/

essentially

  • about terminal entries: menu entries that were created through the menu API can't be turned off through settings
    the proposal is to tweak the jlab code so that they get created throudh settings, so that ultimately we could turn them off here in plugin.json
    so this means that the following won't work, at least for now
        {
          "id": "jp-mainmenu-settings",
          "items": [
            { "command": "terminal:increase-font", "disabled": true},
            { "command": "terminal:decrease-font", "disabled": true},
            { "command": "terminal:set-theme", "disabled": true}
          ]
        },
    
  • about Open in.. entries: should be doable through settings...

it was also mentioned that a more user-friendly interface to the MainMenu class would have been welcome, e.g. for deleting entries based on a regexp..

@parmentelat
Copy link
Owner Author

killer approach was to use disabledExtensions in package.json which is much more effective than trying to turn off individual menu entries

@parmentelat
Copy link
Owner Author

should be good in 0.4.1

@parmentelat
Copy link
Owner Author

parmentelat commented Nov 12, 2023

in a further iteration, we will remove the following entries in mainmenu

  • settings submenu altogether
    • settings / save widget state automatically
  • run / run selected text or current line
  • view / collapse* et view / expand*
  • view / * Sidebar

@parmentelat parmentelat reopened this Nov 12, 2023
parmentelat added a commit that referenced this issue Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant