-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Export modules for AMD consumption #1793
Conversation
Drat. In order for this to work all of the modules will have to be converted to be fully CommonJS. Otherwise the bulk of the modules end up in |
I like it in principle, but I don't like how much work we are making you do on this. @blink1073 what do you think about the tradeoffs in terms of effort of getting webpack to not break requirejs here vs going back to requirejs with no webpack? |
Looking at the |
That makes sense to me. I took a stab at exactly that a while back, but too many webpack changes had been made for it to be really easy, and I ran out of time. |
I'll close this one then. :( |
cf #1554 (comment)
vendor
andmain
using the WebPack DllPlugin.define
functions of the form:./notebook/static/
with''
and./node_modules/
with''
and stripping out the.js
(along with making sure it has a.js
extension first).Here is what the manifest looks like for the
terminal
:And the resulting shim is:
Status
The WebPack bundles and manifests and shims are created and the
tree
page is functional.