[WIP] Export modules for AMD consumption #1793
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #1554 (comment)
vendorandmainusing the WebPack DllPlugin.definefunctions of the form:./notebook/static/with''and./node_modules/with''and stripping out the.js(along with making sure it has a.jsextension first).Here is what the manifest looks like for the
terminal:{ "name": "vendor", "content": { "./notebook/static/terminal/js/main.js": 1, "./node_modules/xterm/src/xterm.css": 2, "./node_modules/css-loader/index.js!./node_modules/xterm/src/xterm.css": 3, "./node_modules/css-loader/lib/css-base.js": 4, "./node_modules/style-loader/addStyles.js": 5 } }And the resulting shim is:
Status
The WebPack bundles and manifests and shims are created and the
treepage is functional.