Backport PR #2066 on branch 4.x #2090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request jupyter#2066 from jupyter/cm-up Patch CodeMirror 5.22
Remove `npm_components()`
|
#2092 should fix the Travis builds once merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge pull request #2066 from jupyter/cm-up
Patch CodeMirror 5.22
Backported manually cause meeseeks don't like backport conflicts.
It was also not responding to @gnestor cause I'm dumb and messed up the comparison of permissions on teams. So I fill in the bot role and backport :-)