Catch error adding link to notebook list #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the fix for jupytergh-223. If a filename can't be decoded in the current encoding, Python escapes the undecodable bytes as unpaired surrogates, which JS doesn't like building a URL from. This doesn't make the undecodable filename openable, but it stops it from breaking the listing of other files. The real fix is to set up the locale encoding correctly so that the filenames can be decoded.
minrk
added a commit
that referenced
this pull request
Jul 23, 2015
Catch error adding link to notebook list closes #223
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for gh-223.
If a filename can't be decoded in the current encoding, Python escapes the undecodable bytes as unpaired surrogates, which JS doesn't like building a URL from.
This doesn't make the undecodable filename openable, but it stops it from breaking the listing of other files.
The real fix is to set up the locale encoding correctly so that the filenames can be decoded.