Allow toolbar buttons to have short label

[takluyver]

I've wanted this for ages - little monochrome icons can only convey so much information. So far, I've only added a label to the run button.

[takluyver]

I propose that we use labels only for a few particularly important buttons (making a bigger target that's easier to click), and for things that aren't otherwise clear. E.g. For cite2c, I want to have a 'Cite' label to highlight what the button group is, because there's no widely recognised icon for citations.

Design choices:

• Not to use the help text from the action: it's typically longer, e.g. "run cell, select below"
• Not to store the label as a new attribute on the action. Conceptually, this is related to the toolbar button, not the underlying action. Also, doing it this way makes it easy to add labels to old-style button definitions that don't use an action.

[minrk]

Makes sense to me. cc @ellisonbg, @Carreau for design.

[Carreau]

Hum, I thought it already supported names. Maybe it's only if there are no icon. But I'm sure I've seen buttons with text.

…

On Apr 24, 2017 08:30, "Min RK" ***@***.***> wrote: Makes sense to me. cc @ellisonbg <https://github.com/ellisonbg>, @Carreau <https://github.com/Carreau> for design. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2433 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUez_MHqqiDQeu85Lzg4RM_zhibKISgks5rzMAcgaJpZM4NEVED> .

[ellisonbg]

I also think this makes sense On Mon, Apr 24, 2017 at 12:17 PM, Matthias Bussonnier < notifications@github.com> wrote:

…

Hum, I thought it already supported names. Maybe it's only if there are no icon. But I'm sure I've seen buttons with text. On Apr 24, 2017 08:30, "Min RK" ***@***.***> wrote: > Makes sense to me. cc @ellisonbg <https://github.com/ellisonbg>, @Carreau > <https://github.com/Carreau> for design. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#2433 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe- auth/AAUez_MHqqiDQeu85Lzg4RM_zhibKISgks5rzMAcgaJpZM4NEVED> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2433 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABr0KwBZzh15iRtju7IbMmuaMYB5f7gks5rzPVEgaJpZM4NEVED> .

-- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

[takluyver]

There doesn't appear to be any other code to add text to the button. If there's no icon specified, it uses the fa-exclamation-triangle icon.

[Carreau]

There doesn't appear to be any other code to add text to the button. If there's no icon specified, it uses the fa-exclamation-triangle icon.

fair enough. I'm pretty sure you brought up the problem before.

[takluyver]

Thanks :-)

[zertrin]

Just a heads-up on a side-effect reported in issue #2845

(do you consider the workaround of disabling it in custom.css the right way of configuring it?)

[Carreau]

Just a heads-up on a side-effect reported in issue #2845

(do you consider the workaround of disabling it in custom.css the right way of configuring it?)

For now; Yes.

[rgbkrk]

Nice, I just noticed this last week with the hide code cell extensions and was really happy that the labels were there now. 😄