-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Play' icon for run-cell toolbar button #2922
Conversation
Based on @ellisonbg's research in jupytergh-2914, most tools with similar functionality to run a piece of code use either the 'play' icon, or something custom designed (RStudio and Spyder are in the latter camp). The analogy with audio and video does suggest that 'step forward' is more similar to running one cell, but it's not clear that users are actually thinking about it in those terms. I'm opening this for discussion rather than for immediate merge.
Thanks @blink1073! I hadn't noticed that Spyder's icon incorporates the 'step forward' icon until I saw it enlarged. |
@SylvainCorlay designed our icons too. |
Yeah I think we should go back to the play button. |
Play button is more simple. If both jupyterlab and nteract are using it, then I think that is enough reason to switch to using it, too. There is another discussion about adding a "restart and run all" button to the toolbar at #2965 and what the icon for that should be. The step-forward icon does imply "run and stop" whereas the play icon doesn't. Please chime in there 👍 |
I am in favor of the play button with no text. See #2965 for related points about toolbar design. |
Circling back here, even if it's 2.5 years later 😆. Looks like everyone is in agreement! I'll give this a couple of days to see if there is any objections—then, I'll plan to merge. Thanks, all! |
Thanks for bumping this thread @Zsailer! |
Based on @ellisonbg's research in gh-2914, most tools with similar functionality to run a piece of code use either the 'play' icon, or something custom designed (RStudio and Spyder are in the latter camp).
The analogy with audio and video does suggest that 'step forward' is more similar to running one cell, but it's not clear whether users are actually thinking about it in those terms.
I'm opening this for discussion, not for immediate merge. cc @SylvainCorlay who originally changed it to 'step forward', and @ssanderson and @rgbkrk who discussed that PR (#201). Sylvain did say at the time that he had seen users confused by it.