Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5.2.0 to changelog #2930

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Add 5.2.0 to changelog #2930

merged 1 commit into from
Oct 12, 2017

Conversation

gnestor
Copy link
Contributor

@gnestor gnestor commented Oct 12, 2017

No description provided.

@gnestor gnestor mentioned this pull request Oct 12, 2017
11 tasks
Copy link
Contributor

@ellisonbg ellisonbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ellisonbg ellisonbg merged commit 65852bb into jupyter:master Oct 12, 2017
@gnestor gnestor deleted the changelog branch October 12, 2017 23:47
@rgbkrk
Copy link
Member

rgbkrk commented Oct 13, 2017

It seems there are a few other items missing from the changelog, which I'm assuming might be my own fault for not adding the output buffering to whatsnew.rst -
there's more here: 5.1.0...5.2.0

(I was also surprised that my name wasn't in the release notes since I made several PRs that were part of 5.2 😉 )

@gnestor
Copy link
Contributor Author

gnestor commented Oct 13, 2017

The issue here is that those PRs were not marked with the 5.2 milestone. I should've double-checked. I just marked them and I will updated the changelog on Github and blog.

@gnestor gnestor added this to the 5.2 milestone Oct 13, 2017
@rgbkrk
Copy link
Member

rgbkrk commented Oct 13, 2017

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants