-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding options to run notebook with kernel gateway #3006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this mostly makes sense, but special-casing kernel handlers doesn't seem quite right. What about sessions
etc.?
Maybe there should be a generic handlers-overrides mechanism that would allow overriding any handlers?
Thanks to the load_handlers
mechanism, this could be a list of modules, e.g. extra_services
to be loaded that are ensured to be loaded at higher priority to the default services.
What do you think?
help=_('The kernel handlers to use.'), | ||
) | ||
|
||
kernelspecs_handlers = Unicode( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: singluar 'kernelspec_handlers' to match 'kernel_handlers'
@minrk It is possible to modify the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @minrk here. Overriding the kernel handler and kernel manager handler was the only requirement for the nb2kg demo. Making the overrides general purpose seems more appropriate for a notebook server feature.
Did not mean to request changes, only comment. Trying again!
Closing for now in favour of #3158 |
resolves #3005