Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /files prefix for PDF-like files #3031

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Use /files prefix for PDF-like files #3031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions notebook/static/tree/js/notebooklist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,12 @@ define([
return model.mimetype === 'text/html'
|| includes_extension(model.path, viewable_extensions);
};

// Files like PDF that should be opened using `/files` prefix
NotebookList.prototype._is_pdflike = function(model) {
var pdflike_extensions = ['pdf'];
return includes_extension(model.path, pdflike_extensions);
};

/**
* Handles when any row selector checkbox is toggled.
Expand Down Expand Up @@ -732,6 +738,10 @@ define([
{
uri_prefix = 'view';
}
if (model.type === 'file' && this._is_pdflike(model))
{
uri_prefix = 'files';
}
if (model.type === 'file' && this._is_notebook(model))
{
uri_prefix = 'notebooks';
Expand Down