Skip to content

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Feb 9, 2018

It would be nice if extra nbconvert exporters show up on the "File -> Download as" menu, without the need to write a custom Javascript extension.

Of course, some exporters will have required parameters, so this system is opt-in -- the exporter must define the export_from_notebook menu to provide a friendly (and possibly translatable) name to the menu.

<li id="download_{{ exporter.name }}">
<a href="#">{{ exporter.display }}</a>
</li>
</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra closing span?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks.

@takluyver takluyver added this to the 5.5 milestone Feb 12, 2018
@takluyver takluyver merged commit 64f02d8 into jupyter:master Feb 12, 2018
@takluyver
Copy link
Member

Thanks!

@mdboom
Copy link
Contributor Author

mdboom commented Feb 12, 2018

Thanks for the merge. Just a heads up (in case it was missed): jupyter/nbconvert#759 documents this feature over in nbconvert land. That seemed like the most logical place, but if not let me know, and I can submit something for notebook.

@takluyver
Copy link
Member

Thanks for the heads up, I had missed that connection. I think the way you've documented it makes sense. :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants