Fixes to improve web accessibility #3507
Conversation
…dded new event handlers for new ids
notebook/static/auth/js/loginmain.js
Outdated
| page_instance.show(); | ||
| $('input#password_input').focus(); | ||
|
|
||
| $('input#token_input').focus(); |
There was a problem hiding this comment.
Focus means putting the cursor in an input so that text will appear there when you start typing. So it doesn't make sense to do it for more than one field.
There was a problem hiding this comment.
@danagilliann and I will be working on this!
notebook/static/auth/js/loginmain.js
Outdated
| @@ -5,9 +5,11 @@ define(['jquery', 'base/js/namespace', 'base/js/page'], function($, IPython, pag | |||
| function login_main() { | |||
| var page_instance = new page.Page('div#header', 'div#site'); | |||
| $('button#login_submit').addClass("btn btn-default"); | |||
| $('button#login_new_pass_submit').addClass("btn btn-default"); | |||
There was a problem hiding this comment.
I think these classes could just be written directly in the HTML, rather than being added by Javascript. I can see it's copied from the line above, but I don't know why that's done in Javascript either.
There was a problem hiding this comment.
sure thing, we’ll fix it!
There was a problem hiding this comment.
@danagilliann and I will be working on this!
|
Feel free to comment when you have pushed and pull-requests are ready for further review, we are not notified on push |
|
I am actually notified on push now. I thought Github was doing that for everyone? I don't remember changing a setting. Anyway, this looks good now - thanks all of you who worked on it. |
This PR fixes #3471
Changes
langattribute (generated dynamically) which describes the language of the documentHow the page looks after the changes