"Require" pyzmq>=17 #3586
Merged
"Require" pyzmq>=17 #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not really a requirement, but explaining about the pyzmq/tornado incompatibility gets old fast. Closes jupytergh-3579
|
Thomas, quick question: should this be done for qtconsole too? |
|
Possibly. Have you had many people raising issues due to this incompatibility? I just got tired of explaining it repeatedly, so this should get more people upgraded. |
Yep, we've had our share of issues about it. I'll open a PR i qtconsole to address it then. |
|
Min already agreed to the idea of doing this, so I'm merging it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really a requirement, but explaining about the pyzmq/tornado incompatibility gets old fast.
Closes gh-3579