updates changelog in prep for releasing5.6rc #3688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! We should also make sure to resolve #3668 before we release 5.6. |
takluyver
reviewed
Jun 15, 2018
docs/source/changelog.rst
Outdated
|
|
||
| Testing: | ||
| - Add find replace test (:ghpull:`3630`) | ||
| - [3335] Convert JS tests to Selenium (:ghpull:`3601`) |
There was a problem hiding this comment.
Let's get rid of the [3335], and preferably be more specific which JS tests were converted. Unfortunately PR titles don't all make good release notes.
takluyver
reviewed
Jun 15, 2018
docs/source/changelog.rst
Outdated
|
|
||
| New features: | ||
|
|
||
| - Execute cells by clicking area in input prompt (:ghpull:`3535`, :ghpull:`3687`) |
There was a problem hiding this comment.
This got changed from an invisible area to an icon
takluyver
reviewed
Jun 15, 2018
| - Include LICENSE file in wheels (:ghpull:`3671`) | ||
|
|
||
| Testing: | ||
| - Add find replace test (:ghpull:`3630`) |
There was a problem hiding this comment.
You may need a blank line above this, I'm not sure.
|
I've updated the changelog with the latest PRs we've merged. |
|
Ok then I'll move forward with the release @takluyver thanks for the help & merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to update the changelog before the 5.6 release candidate.
Once we merge this unless someone else specifically objects I'm going to move forward with getting 5.6rc1 out the door.
@takluyver @Carreau @minrk