-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mathjax #3751
Upgrade mathjax #3751
Conversation
It looks like there's an official MathJax package:
Does this mean that @minrk doesn't need to maintain components/mathjax? It looks like one difference is that components/mathjax purposefully excludes the image fonts... |
@takluyver I'm getting a strange error when trying to run the notebook against master:
I tested the upgraded mathjax against the |
Thanks @gnestor, I've tested that. I think you're running into some issue with #3714. Can I ask that you open a new issue for that and mark it for 5.6 to make sure we investigate promptly? For some reason it seems to be determining that |
Indeed we should investigate picking up the official mathjax package, if it works. We can (and maybe do already?) exclude the image fonts in our package_data setup. |
Opened #3755 for further discussion of that. |
Should we do a patch release? 5.5.1? Or just wait for 5.6.0? |
We were on the cusp of releasing 5.6 anyway, so let's just do that. |
@takluyver @minrk