Skip to content

Conversation

@dubielt1
Copy link

This is a contribution to issue #3335 converting js tests to selenium. This contains the conversion of the file notebook/tests/notebook/kernel_menu.js

@dubielt1
Copy link
Author

@takluyver I looked through the travis-ci logs and my test was the only one with this error: Error opening stream: HTTP 404: Not Found (Kernel does not exist: 73b65ed7-2d99-4549-af2f-35fb69a9b70e)

It seems to say a kernel connection wasn't established, so when the test code clicked the shutdown kernel button, the confirmation dialog never appeared, causing the TimeoutException

Maybe we can try re-running the tests? Let me know if I've overlooked anything

@takluyver
Copy link
Member

I've hit restart. For future reference you can usually restart tests by closing and reopening the pull request on Github (no need to open a new one - after you close, there's a button to reopen it).

It looks like the failure was in the test you converted, though, so it's worth looking into even if it's an intermittent failure.

@takluyver
Copy link
Member

Still failing. From the log, it looks like the kernel is started, then shutdown, and then something tries to connect to it after it is shut down.

@dubielt1
Copy link
Author

I've hit restart. For future reference you can usually restart tests by closing and reopening the pull request on Github (no need to open a new one - after you close, there's a button to reopen it).

It looks like the failure was in the test you converted, though, so it's worth looking into even if it's an intermittent failure.

Thanks for the tip.

I'll work on reproducing the failure locally this evening, but in my initial runs it passed.

@takluyver
Copy link
Member

@dubielt1 Do you think you'll have time to look at this again?

@dubielt1
Copy link
Author

dubielt1 commented Nov 7, 2018 via email

@takluyver
Copy link
Member

Happy new year! Do you think you'll have time to look at this pull request again?

@takluyver
Copy link
Member

I've rebased and updated this to try to get it finished.

@takluyver takluyver merged commit 9640e1f into jupyter:master Nov 9, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants