-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Translated kernel menu javascript test to selenium #4101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@takluyver I looked through the travis-ci logs and my test was the only one with this error: It seems to say a kernel connection wasn't established, so when the test code clicked the shutdown kernel button, the confirmation dialog never appeared, causing the Maybe we can try re-running the tests? Let me know if I've overlooked anything |
|
I've hit restart. For future reference you can usually restart tests by closing and reopening the pull request on Github (no need to open a new one - after you close, there's a button to reopen it). It looks like the failure was in the test you converted, though, so it's worth looking into even if it's an intermittent failure. |
|
Still failing. From the log, it looks like the kernel is started, then shutdown, and then something tries to connect to it after it is shut down. |
Thanks for the tip. I'll work on reproducing the failure locally this evening, but in my initial runs it passed. |
|
@dubielt1 Do you think you'll have time to look at this again? |
|
Yes, I'll give it another look this week
…On Wed, Nov 7, 2018, 05:53 Thomas Kluyver ***@***.***> wrote:
@dubielt1 <https://github.com/dubielt1> Do you think you'll have time to
look at this again?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALFLedUHSm3hwTm-tDmwRSsHUNFeA05Dks5ussnWgaJpZM4Xa8Gy>
.
|
|
Happy new year! Do you think you'll have time to look at this pull request again? |
a2613f0 to
92db6a7
Compare
|
I've rebased and updated this to try to get it finished. |
This is a contribution to issue #3335 converting js tests to selenium. This contains the conversion of the file notebook/tests/notebook/kernel_menu.js