Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case sensitive notebook file extension #4355

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

EvgeniDubov
Copy link
Contributor

@EvgeniDubov EvgeniDubov commented Jan 20, 2019

In case a notebook file extension is not all lower case (e.g. NOTE.IPYNB) then notebook will identify it as plain text.
My fix is making the notebook file extension check to be case insensitive

@takluyver
Copy link
Member

We might need to do something to make this work correctly in Turkish locales, where there are two different kinds of i, becauses I think IPYNB there will be lowercased to ıpynb (missing the dot). I'm not sure how to easily work around that.

Otherwise, this seems reasonable to me, I'll give it a day or two unless anyone else has a different opinion.

To be clear, I'd still regard lower-case .ipynb as the canonical file extension, and I'd recommend that any tools writing a notebook file do so with that extension.

@EvgeniDubov
Copy link
Contributor Author

Thanks for the feedback @takluyver

Interesting point about the Turkish latter, thank you.

Regarding the upper case extension, I totally agree with your recommendation.
The way I found the issue was that someone sent me a notebook file with lower case extension by email but outlook changed the attached file extension to upper case.
You can see a discussion on that issue here:
https://superuser.com/questions/1207156/disable-attachment-file-name-extension-case-conversion-in-outlook

@minrk minrk added this to the 5.8 milestone Feb 25, 2019
@minrk minrk merged commit 6a96754 into jupyter:master Feb 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants