Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: shutdown_server returns True when pid exists #4674

Merged
merged 1 commit into from
Jun 25, 2019
Merged

bugfix: shutdown_server returns True when pid exists #4674

merged 1 commit into from
Jun 25, 2019

Commits on Jun 13, 2019

  1. bfix: shutdown_server returns True when pid exists 

    `check_pid` returns `True` if the PID for a notebook server still exists. Therefore, the `if check_pid(pid):` statements on lines 424 and 437 evaluate to `True` even though the notebook server is still running.

This commit simply adds a `not` to each line: `if not check_pid(pid):` so that the conditional only evaluates to `True` if `check_pid` returns `False`, which happens when the notebook server has shutdown, as expected.
    @asreimer
    asreimer authored Jun 13, 2019
    Configuration menu
    Copy the full SHA
    dd0f5d2 View commit details
    Browse the repository at this point in the history