Name of the "EditTextbox" is missing: #3977 #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
reviewed
Jul 7, 2019
| @@ -166,6 +166,7 @@ define([ | |||
| "is treated as tag separators."); | |||
|
|
|||
| var textarea = $('<textarea/>') | |||
| .attr('aria-label', 'Edit the tags in the text area') | |||
There was a problem hiding this comment.
Suggested change
| .attr('aria-label', 'Edit the tags in the text area') | |
| .attr('aria-label', i18n.msg._('Edit the tags in the text area')) |
There was a problem hiding this comment.
I think this will make it localizable, so users in other languages will hear it in their own language
There was a problem hiding this comment.
Thanks for the suggestion. I have made the necessary changes.
yuvipanda
previously requested changes
Jul 7, 2019
| @@ -166,6 +166,7 @@ define([ | |||
| "is treated as tag separators."); | |||
|
|
|||
| var textarea = $('<textarea/>') | |||
| .attr('aria-label', 'Edit the tags in the text area') | |||
There was a problem hiding this comment.
I think this will make it localizable, so users in other languages will hear it in their own language
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the issue #3977 by adding the aria-label attribute. So now the name of the edit textbox is announced by the narrator.